Skip to content

Add is_input_actioned.tres #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Add is_input_actioned.tres #222

merged 1 commit into from
Sep 24, 2024

Conversation

dylanmccall
Copy link
Contributor

@dylanmccall dylanmccall commented Sep 18, 2024

This adds a block extension script to generate an options list instead of BlocksCatalog._get_inputmap_actions.

@dylanmccall dylanmccall changed the title Input block extension Add is_input_actioned.tres Sep 18, 2024
@dylanmccall dylanmccall force-pushed the input-block-extension branch 3 times, most recently from 10a1fa4 to 5ecd03b Compare September 19, 2024 18:56
@dylanmccall dylanmccall marked this pull request as ready for review September 19, 2024 18:59
Copy link
Contributor

@starnight starnight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for helping move the input key action block into a single tres. I place some review comments. :)

This replaces the block definition generated in BlocksCatalog. Instead,
the static block definition includes an extension script which generates
a list of action name options.
@dylanmccall
Copy link
Contributor Author

Thanks for the review @starnight! I fixed those details in the newest commit.

@starnight starnight merged commit d02b932 into main Sep 24, 2024
3 checks passed
@starnight starnight deleted the input-block-extension branch September 24, 2024 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants