Get protected root path once #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbanner
approved these changes
Feb 19, 2025
quanmaiepi
force-pushed
the
bugfix/protected-root-path
branch
from
f97fcd6 to
625586b
Compare
As Shell.Paths.ProtectedRootPath uses ServiceLocator.Current.GetInstance internally calling it every time will be expensive as dependency will have to be built. As the property is readonly, we only need to get it once for the life time of the app
quanmaiepi
force-pushed
the
bugfix/protected-root-path
branch
from
625586b to
c3d46b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Shell.Paths.ProtectedRootPath uses
ServiceLocator.Current.GetInstance internally
calling it every time will be expensive as
dependency will have to be built. As the property
is readonly, we only need to get it once for the life time of the app