Skip to content

update install doc: helm get package version from Erda VERSION #800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 8, 2021

Conversation

sfwn
Copy link
Member

@sfwn sfwn commented Jul 7, 2021

What type of this PR

/kind document

What this PR does / why we need it:

Helm get package version from Erda VERSION, not fixed 0.1.0.

Need cherry-pick to release versions?

/cherry-pick master

For details on the cherry pick process, see the cherry pick requests section under CONTRIBUTING.md.

@sfwn
Copy link
Member Author

sfwn commented Jul 7, 2021

related erda-release pr: v1.0.1: update image; add VERSION for helm install

@codecov
Copy link

codecov bot commented Jul 7, 2021

Codecov Report

Merging #800 (f21266e) into release/1.0 (a0def33) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           release/1.0    #800   +/-   ##
===========================================
  Coverage         9.34%   9.35%           
===========================================
  Files              996     996           
  Lines            90741   90741           
===========================================
+ Hits              8484    8486    +2     
+ Misses           81365   81363    -2     
  Partials           892     892           
Impacted Files Coverage Δ
pkg/mock/mock.go 26.02% <0.00%> (+2.73%) ⬆️

Effet
Effet previously requested changes Jul 8, 2021
@Effet
Copy link
Member

Effet commented Jul 8, 2021

and why this pr targeting to release/1.0 not master

@sfwn
Copy link
Member Author

sfwn commented Jul 8, 2021

and why this pr targeting to release/1.0 not master

Make sure release/1.0 is ok firstly.

@Muzry
Copy link
Contributor

Muzry commented Jul 8, 2021

lgtm

@sfwn sfwn requested a review from Effet July 8, 2021 07:44
@luobily
Copy link
Member

luobily commented Jul 8, 2021

/approve

erda-bot
erda-bot previously approved these changes Jul 8, 2021
@sfwn sfwn force-pushed the doc/helm-install-version branch from d12a536 to 9b3d5c7 Compare July 8, 2021 08:02
@sfwn sfwn dismissed Effet’s stale review July 8, 2021 08:19

resovled

@erda-bot erda-bot merged commit 0ac4f8f into erda-project:release/1.0 Jul 8, 2021
@sfwn sfwn deleted the doc/helm-install-version branch July 8, 2021 08:29
@sfwn
Copy link
Member Author

sfwn commented Jul 8, 2021

/cherry-pick master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants