-
Notifications
You must be signed in to change notification settings - Fork 376
update install doc: helm get package version from Erda VERSION #800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
erda-bot
merged 2 commits into
erda-project:release/1.0
from
sfwn:doc/helm-install-version
Jul 8, 2021
Merged
update install doc: helm get package version from Erda VERSION #800
erda-bot
merged 2 commits into
erda-project:release/1.0
from
sfwn:doc/helm-install-version
Jul 8, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
related erda-release pr: v1.0.1: update image; add VERSION for helm install |
Codecov Report
@@ Coverage Diff @@
## release/1.0 #800 +/- ##
===========================================
Coverage 9.34% 9.35%
===========================================
Files 996 996
Lines 90741 90741
===========================================
+ Hits 8484 8486 +2
+ Misses 81365 81363 -2
Partials 892 892
|
Effet
previously requested changes
Jul 8, 2021
and why this pr targeting to release/1.0 not master |
Make sure release/1.0 is ok firstly. |
lgtm |
/approve |
erda-bot
previously approved these changes
Jul 8, 2021
d12a536
to
9b3d5c7
Compare
erda-bot
approved these changes
Jul 8, 2021
/cherry-pick master |
erda-bot
added a commit
to erda-bot/erda
that referenced
this pull request
Jul 8, 2021
…ION (erda-project#800) Co-authored-by: erda-bot <[email protected]>
sfwn
added a commit
that referenced
this pull request
Jul 8, 2021
…ION (#800) (#817) Co-authored-by: erda-bot <[email protected]> Co-authored-by: sfwn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of this PR
/kind document
What this PR does / why we need it:
Helm get package version from Erda VERSION, not fixed 0.1.0.
Need cherry-pick to release versions?
/cherry-pick master