feat: add support for baseline years #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for putting this together. I'm not sure how useful this feature is, so let's discuss back on #78 before iterating on the code. |
nzakas
reviewed
Mar 13, 2025
nzakas
reviewed
Mar 14, 2025
nzakas
reviewed
Mar 14, 2025
src/rules/require-baseline.js
Outdated
| // baseline year | ||
| type: "integer", | ||
| minimum: 2000, | ||
| maximum: new Date().getFullYear() + 1, |
There was a problem hiding this comment.
Double-checking: is this intentional? The max now would be 2026?
Or did you mean this?
Suggested change
| maximum: new Date().getFullYear() + 1, | |
| maximum: new Date().getFullYear() - 1, |
There was a problem hiding this comment.
Ah, yes this was intentional (see #81 (comment)) but I just realized the maximum is inclusive. My reasoning was that the current year is technically a valid Baseline year, ie https://web.dev/baseline/2025.
Fixed this to use the current year, but let me know if you'd still prefer YYYY - 1.
nzakas
approved these changes
Mar 14, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
Adds the ability to configure the require-baseline rule to target a Baseline year as an alternative to newly or widely available status
What changes did you make? (Give an overview)
availableconfiguration property enumBaselineAvailabilityclass to determine whether a feature is supported based on the configRelated Issues
fixes #78
Is there anything you'd like reviewers to focus on?
For the rule schema, would you prefer to configure the baseline year as a separate optional property, rather than shoehorning it in with
available?