Skip to content

chore: use defineConfig and globalIgnores in ESLint config #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

lumirlumir
Copy link
Contributor

Prerequisites checklist

What is the purpose of this pull request?

Hello,

I've updated ESLint config file to use defineConfig and globalIgnores which was added recently, and I also bumped ESLint to the latest version.

What changes did you make? (Give an overview)

Related Issues

Is there anything you'd like reviewers to focus on?

@lumirlumir lumirlumir mentioned this pull request Apr 26, 2025
28 tasks
@lumirlumir lumirlumir requested a review from mdjermanovic April 26, 2025 10:53
@lumirlumir lumirlumir requested a review from nzakas May 4, 2025 11:10
@lumirlumir
Copy link
Contributor Author

@mdjermanovic Thank you!

I've added a new commit in d8b46d5

Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Leaving open for @nzakas to verify.

@github-project-automation github-project-automation bot moved this to Needs Triage in Triage May 4, 2025
@mdjermanovic mdjermanovic moved this from Needs Triage to Second Review Needed in Triage May 4, 2025
Copy link
Contributor

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@nzakas nzakas merged commit 19d9319 into eslint:main May 5, 2025
16 checks passed
@github-project-automation github-project-automation bot moved this from Second Review Needed to Complete in Triage May 5, 2025
@lumirlumir lumirlumir deleted the chore-use-define-config-and-global-ignores-in-eslint-config branch May 5, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

4 participants