Skip to content

feat(board): add Satellite 1 CORE (rev 5.1) #11360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ericlewis
Copy link
Contributor

@ericlewis ericlewis commented May 13, 2025

Description of Change

Add the Satellite 1 CORE (rev 5.1) from FutureProofHomes.

Tests scenarios

I have tested my Pull Request on the board itself using:

#include <Arduino.h>

void setup() {
  Serial.begin(115200);
  while (!Serial && millis() < 3000) ;   // wait for the host (max 3 s)

  pinMode(LED_BUILTIN, OUTPUT);

  if (!psramFound()) {
    Serial.println("PSRAM not detected!");
    return;
  }

  uint32_t bytes = ESP.getPsramSize();   // 0, 2 048 000, 4 194 304, 8 388 608
  Serial.printf("PSRAM size : %u bytes\n", bytes);
  Serial.printf("PSRAM mode : %s (inferred)\n",
                bytes >= 8 * 1024 * 1024 ? "Octal" : "Quad");
}

void loop() {
  digitalWrite(LED_BUILTIN, HIGH);
  delay(500);
  digitalWrite(LED_BUILTIN, LOW);
  delay(500);
}

Links

The relevant spec: https://github.com/FutureProofHomes/Satellite1-Hardware/blob/main/core/rev5.1coreSCH.pdf

Copy link
Contributor

github-actions bot commented May 13, 2025

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello ericlewis, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 62144b8

Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ericlewis PTAL on my comments

Comment on lines +50209 to +50213
sat1core_rev5_1.menu.FlashMode.qio=QIO 80MHz
sat1core_rev5_1.menu.FlashMode.qio.build.flash_mode=dio
sat1core_rev5_1.menu.FlashMode.qio.build.boot=qio
sat1core_rev5_1.menu.FlashMode.qio.build.boot_freq=80m
sat1core_rev5_1.menu.FlashMode.qio.build.flash_freq=80m
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can run a OPI Flash mode as your module has OPI PSRAM, if you don't have something custom. Can you check?

Comment on lines +50255 to +50263
sat1core_rev5_1.menu.PartitionScheme.gen4esp32scheme1=Small App w/ OTA + Huge FS (2MB APP/2MB OTA/12MB SPIFFS)
sat1core_rev5_1.menu.PartitionScheme.gen4esp32scheme1.build.custom_partitions=gen4esp32_2MBapp_2MBota_12MBspiffs
sat1core_rev5_1.menu.PartitionScheme.gen4esp32scheme1.upload.maximum_size=2097152
sat1core_rev5_1.menu.PartitionScheme.gen4esp32scheme2=Medium App w/ OTA + Large FS (4MB APP/4MB OTA/7MB SPIFFS)
sat1core_rev5_1.menu.PartitionScheme.gen4esp32scheme2.build.custom_partitions=gen4esp32_4MBapp_4MBota_7MBspiffs
sat1core_rev5_1.menu.PartitionScheme.gen4esp32scheme2.upload.maximum_size=4718592
sat1core_rev5_1.menu.PartitionScheme.gen4esp32scheme3=Large App w/ OTA (8MB APP/8MB OTA)
sat1core_rev5_1.menu.PartitionScheme.gen4esp32scheme3.build.custom_partitions=gen4esp32_8MBapp_8MBota
sat1core_rev5_1.menu.PartitionScheme.gen4esp32scheme3.upload.maximum_size=8323072
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work, as those partitions does not exist in the core. You have to use the ones we have and provide a "Custom" option there also, where users can you your custom ones you can provide in your docs or some repo :)

Comment on lines +53 to +58
static const uint8_t A0 = 1; static const uint8_t T4 = 4;
static const uint8_t A1 = 2; static const uint8_t T5 = 5;
static const uint8_t A2 = 3; static const uint8_t T6 = 6;
static const uint8_t A3 = 4; static const uint8_t T7 = 7;
static const uint8_t A4 = 6; static const uint8_t T8 = 8;
static const uint8_t A5 = 7;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a formatting here.

Suggested change
static const uint8_t A0 = 1; static const uint8_t T4 = 4;
static const uint8_t A1 = 2; static const uint8_t T5 = 5;
static const uint8_t A2 = 3; static const uint8_t T6 = 6;
static const uint8_t A3 = 4; static const uint8_t T7 = 7;
static const uint8_t A4 = 6; static const uint8_t T8 = 8;
static const uint8_t A5 = 7;
static const uint8_t A0 = 1;
static const uint8_t A1 = 2;
static const uint8_t A2 = 3;
static const uint8_t A3 = 4;
static const uint8_t A4 = 6;
static const uint8_t A5 = 7;
static const uint8_t T4 = 4;
static const uint8_t T5 = 5;
static const uint8_t T6 = 6;
static const uint8_t T7 = 7;
static const uint8_t T8 = 8;

@P-R-O-C-H-Y P-R-O-C-H-Y added the Status: In Progress ⚠️ Issue is in progress label May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants