Skip to content

Apply this change to 2.0.9 #8131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 3, 2023
Merged

Apply this change to 2.0.9 #8131

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9072d84
Fix the F_CPU frequency for the ESP32-S3
devrim-oguz Mar 1, 2023
652dd1c
Makes F_CPU generic based on the SoC frequency
SuGlider Mar 30, 2023
4863b5b
Includes ESP32C3 in the F_CPU definition
SuGlider Mar 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix the F_CPU frequency for the ESP32-S3 
Hello, I was using the FastLED library and it was complaining about F_CPU not being defined. So, I just noticed that it is not defined for the ESP32-S3 module. So I made this change in the header file and it compiled. Therefore I wanted to propose this change to the HAL library to improve compatibility. Thank you for your time.
  • Loading branch information
@devrim-oguz
devrim-oguz authored Mar 1, 2023
commit 9072d8444cc8e2e8a5e47491f34d3dfaccf9760d
2 changes: 2 additions & 0 deletions cores/esp32/esp32-hal.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,8 @@ extern "C" {
#define F_CPU (CONFIG_ESP32_DEFAULT_CPU_FREQ_MHZ * 1000000U)
#elif CONFIG_IDF_TARGET_ESP32S2
#define F_CPU (CONFIG_ESP32S2_DEFAULT_CPU_FREQ_MHZ * 1000000U)
#elif CONFIG_IDF_TARGET_ESP32S3
#define F_CPU (CONFIG_ESP32S3_DEFAULT_CPU_FREQ_MHZ * 1000000U)
#endif
#endif

Expand Down