user agent messages were dumped in some cases #1710
Merged
+48
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated: Tue Aug 25 08:08:38 UTC 2015 |
zelig
changed the title
|
👍 |
1 similar comment
|
👍 |
fjl
added a commit
that referenced
this pull request
Aug 25, 2015
user agent messages were dumped in some cases
Gustav-Simonsson
pushed a commit
to Gustav-Simonsson/go-ethereum
that referenced
this pull request
Aug 25, 2015
user agent messages were dumped in some cases (cherry picked from commit a219159)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a missing commit the console didn't handle user agents reponses in the correct way. This causes the console to block until a timeout occurs. This PR will send the user agent response to geth and doesn't block the console.
This fixes #1700