This repository was archived by the owner on Jun 13, 2023. It is now read-only.
Rebuild app online #392
Closed
Rebuild app online #392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes wall to wallet
* Set placeholder contract's pragma version using Mist-API * add comment * improvements * add further conditions
* added @frozeman's fix (#328) * updates for gh-pages (#331) * Update README (#335) Changes wall to wallet * Set placeholder contract's pragma version using Mist-API (#337) * Set placeholder contract's pragma version using Mist-API * add comment * improvements * add further conditions * added missing 0x * build
* Error handling for previous versions of Mist * Better checking of Mist object
I'm inferring from #118 that address parameters need quotes.
* make correction to fr translation * meteor: add ES6 support
* Adding out of sync warning to EN and PT * Adding etherscan button on sidebar * Translations * added german
Changed http:// to https:// on one link in README.md
* fix contract ordering * check if function payable * remove console log
* Adding two more currencies to price ticker * updating ethereum:tools package to 0.7.0
* Updating coinbase success message Signed-off-by: Everton Fraga <[email protected]> * Updating coinbase success message
* remove disabled wallets * removed disabled wallets
frozeman
reviewed
Jun 29, 2017
app/client/templates/views/send.html
Outdated
| @@ -1,7 +1,5 @@ | |||
| <template name="views_send"> | |||
|
|
|||
| {{reactiveData}} | |||
|
|
|||
There was a problem hiding this comment.
Why is this removed??
This was necessary to trigger reactivity in the respective function
|
|
||
| // Deploy contract | ||
| if(FlowRouter.getRouteName() === 'deployContract') { | ||
| TemplateVar.set('selectedAction', 'deploy-contract'); |
There was a problem hiding this comment.
Only setting this here. Doesn't make itvreactive for token changes.
There was a problem hiding this comment.
@frozeman Are the build files done correctly and added and the old ones removed?
Yes, they are.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.