abi-coder: name is not defined

[dwalintukan]

Receiving name is not defined crash in utils/abi-coder.js L483.

Looked at the source code and it looks like it should be this.name:
errors.throwError('insufficient data for ' + name + ' type', errors.INVALID_ARGUMENT, {

(node:17) UnhandledPromiseRejectionWarning: ReferenceError: name is not defined
    at CoderFixedBytes.decode (/root/bodhi-server/node_modules/ethers/utils/abi-coder.js:483:58)
    at CoderAnonymous.decode (/root/bodhi-server/node_modules/ethers/utils/abi-coder.js:338:83)
    at /root/bodhi-server/node_modules/ethers/utils/abi-coder.js:688:32
    at Array.forEach (<anonymous>)
    at unpack (/root/bodhi-server/node_modules/ethers/utils/abi-coder.js:680:12)
    at CoderArray.decode (/root/bodhi-server/node_modules/ethers/utils/abi-coder.js:779:22)
    at /root/bodhi-server/node_modules/ethers/utils/abi-coder.js:688:32
    at Array.forEach (<anonymous>)
    at unpack (/root/bodhi-server/node_modules/ethers/utils/abi-coder.js:680:12)
    at CoderTuple.decode (/root/bodhi-server/node_modules/ethers/utils/abi-coder.js:807:22)
    at AbiCoder.decode (/root/bodhi-server/node_modules/ethers/utils/abi-coder.js:956:61)
    at AbiCoder.decodeParameters (/root/bodhi-server/node_modules/web3-eth-abi/dist/web3-eth-abi.cjs.js:66:40)
    at CallContractMethod.afterExecution (/root/bodhi-server/node_modules/web3-eth-contract/dist/web3-eth-contract.cjs.js:725:30)
    at CallContractMethod._callee$ (/root/bodhi-server/node_modules/web3-core-method/dist/web3-core-method.cjs.js:109:35)
    at tryCatch (/root/bodhi-server/node_modules/@babel/runtime/node_modules/regenerator-runtime/runtime.js:45:40)
    at Generator.invoke [as _invoke] (/root/bodhi-server/node_modules/@babel/runtime/node_modules/regenerator-runtime/runtime.js:271:22)

[ricmoo]

Ack... Yes I will fix that right away and update this ticket when it is published.

This seems to be a problem with TypeScript, in general. @naddison36, any idea why in TypeScript any variable named name seems to be completely ignored by the type-checking and blessed to be used in wildly wrong ways without triggering any compiler warnings? Is there any compiler flag to fix this?

I will do a wider search as well for other variables named name as well.

Since the only problem is that a wrong error is thrown (an error would still otherwise be thrown, just a more meaningful one), it isn't super high priority, so I may not get the fix published until tomorrow, but will try for later today.

[ricmoo]

This should be addressed in 4.0.30. Please try it out and let me know if you still have any problems.

Thanks! :)

[dwalintukan]

Thanks @ricmoo