Skip to content

Fix zero address check in lookupAddress() #4086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix zero address check in lookupAddress() #4086

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src.ts/providers/abstract-provider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
// of Signer/ENS name to address so we can sync respond to listenerCount.

import { getAddress, resolveAddress } from "../address/index.js";
import { ZeroHash } from "../constants/index.js";
import { ZeroAddress } from "../constants/index.js";
import { Contract } from "../contract/index.js";
import { namehash } from "../hash/index.js";
import { Transaction } from "../transaction/index.js";
Expand Down Expand Up @@ -985,7 +985,7 @@ export class AbstractProvider implements Provider {
], this);

const resolver = await ensContract.resolver(node);
if (resolver == null || resolver === ZeroHash) { return null; }
if (resolver == null || resolver === ZeroAddress) { return null; }

const resolverContract = new Contract(resolver, [
"function name(bytes32) view returns (string)"
Expand Down