Skip to content

Remove 4.x go.mod to make semantic versions addressable by tag #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2020

Conversation

liggitt
Copy link
Contributor

@liggitt liggitt commented Aug 8, 2020

As noted in #98, the presence of a go.mod file in the root of the module in tagged semantic versions >= v2.x means go module consumers cannot address v4.x releases using semantic versions

For example, the recently tagged v4.8.0 has to be referred to as v0.0.0-20200808040245-162e5629780b, directly referencing the git SHA.

#100 resolved this for v5+, but removing the go.mod in the module root would allow v4.x consumers to resume referencing semantic version.

If this was merged and a v4.9.0 release tagged, consumers could do go get github.com/evanphx/[email protected] and record the tagged release in their go.mod files correctly.

This is more of a tidyness issue than a functional one (it makes the versions recorded in consumers' go.mod files easier to understand, but doesn't actually change the code that is run), though if consumers have to refer to v4.8.0 as v0.0.0-20200808040245-162e5629780b, go module version selection can get confused and prefer v4.6.0-incompatible thinking it is newer.

@evanphx
Copy link
Owner

evanphx commented Aug 12, 2020

I'm still confused on how go modules pick this stuff up honestly, so I'll take your word for it.

@evanphx evanphx merged commit d05b386 into evanphx:master Aug 12, 2020
@liggitt
Copy link
Contributor Author

liggitt commented Aug 12, 2020

thanks, all that is needed now is a v4.9.0 tag and we'll be back to semver-addressable versions on the 4.x stream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants