Skip to content

Added .editorconfig #3221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

wesleytodd
Copy link
Member

Auto-configure editors for 2 space indention. There are a few more options we could set, see here for more:

https://github.com/editorconfig/editorconfig/wiki/EditorConfig-Properties

@dougwilson
Copy link
Contributor

I'm generally 👎 to adding these to repos, but would like to hear from others and what the thoughts are :)

@wesleytodd
Copy link
Member Author

wesleytodd commented Feb 24, 2017

Thats fine, I can make this work for myself in other ways, I just looked for a more standard/common solution. The issue is that I default my editor to tabs, so every time I submit a PR I have to pour over it to make sure I got all the indentation correct. In this crazy world we live in where people think it is sane to use spaces ;), this is one way to ease it for tabs people.

PS. to make it obvious, I was joking about the tab/spaces thing. But I seriously just want my editor to fix these things for me.

EDIT: Also, on other projects I use standard to just auto-format. But the state of the express repo means I cannot do that, because it would introduce TONS of unintended changes.

@LinusU
Copy link
Member

LinusU commented Feb 26, 2017

I would normally be 👎, but this:

EDIT: Also, on other projects I use standard to just auto-format. But the state of the express repo means I cannot do that, because it would introduce TONS of unintended changes.

make me 👍, at least until we have everything following standard style :)

@notrab
Copy link
Contributor

notrab commented Mar 8, 2017

I'd go as far as saying implementing a linting tool would be better suited considering the inconsistencies within the app around code style. The linting could then take into account the aforementioned .editorconfig.

@dougwilson
Copy link
Contributor

Yes, we are implementing StandardJS, but trying to balance implementing that with it causing a complete reformat of the code, pretty much invalidating any outstanding PRs :)

@dougwilson dougwilson self-assigned this Mar 19, 2017
@dougwilson
Copy link
Contributor

Well, I'm going to merge this PR for everyone, and I remove the trailing line exception from Markdown files (and fixed the markdown file with all those trailing new lines). Also needed to remove the LF line ending thing because Windows users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants