Fix exit code for call subcommand when tool execution fails #58
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
call
subcommand was not returning proper exit codes when encountering execution errors (such as calling unknown tools). This made it impossible to use the tool effectively in CI pipelines and validation scripts.Problem
Before this fix:
The command would print the error message but exit with code 0, making it difficult to detect failures in automated environments.
Solution
Added proper error handling to check for execution errors (
execErr
) after calling MCP client methods and exit with code 1 when errors occur.After this fix:
Now the command correctly exits with code 1 for execution errors while maintaining code 0 for successful operations.
Changes Made
cmd/mcptools/commands/call.go
to check for execution errors and exit with code 1This enables proper use of mcptools in CI pipelines and validation workflows where non-zero exit codes are essential for detecting failures.
Fixes #53.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.