Skip to content

Bump minimal Node version to 6 #1897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 9, 2017
Merged

Bump minimal Node version to 6 #1897

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f36d25f
Bump minimal Node version to 4.7.0
ianschmitz Mar 27, 2017
e9adb19
Merge remote-tracking branch 'upstream/master'
ianschmitz Mar 30, 2017
15db7b2
Bump minimal Node version to 4.7.0
ianschmitz Mar 30, 2017
709d3c2
Bump minimal Node version to 4.7.0
ianschmitz Mar 30, 2017
1689736
Merge remote-tracking branch 'upstream/master'
May 8, 2017
b1d8941
Bump minimal node version to 6
May 8, 2017
53c90ad
Bump minimal node version to 6
May 8, 2017
1c6bbf2
Bump minimal node version to 6
May 8, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Bump minimal node version to 6
  • Loading branch information
Ian Schmitz committed May 8, 2017
commit 1c6bbf2851d55fb40c72095ba429bed6bdc08b07
2 changes: 1 addition & 1 deletion tasks/e2e-simple.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ cd "$root_path"/packages/create-react-app
npm install
cd "$root_path"

# If the node version is < 4.7, the script should just give an error.
# If the node version is < 6, the script should just give an error.
nodeVersion=`node --version | cut -d v -f2`
nodeMajor=`echo $nodeVersion | cut -d. -f1`
nodeMinor=`echo $nodeVersion | cut -d. -f2`
Expand Down