Move RefreshControlMock into Jest preset files #51530
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D75215731 |
Summary: Pull Request resolved: facebook#51530 Alternative to facebook#50784. `__mocks__` (and other underscored dirs) are correctly excluded from our npm package via `package.json#files`. But in this instance, this is a source file for the `jest/` directory (Jest preset within `react-native`), and should be included — fix by relocating. Changelog: [General][Fixed] - Fix missing RefreshControlMock source in Jest preset Reviewed By: rshest Differential Revision: D75215731
|
This pull request was exported from Phabricator. Differential Revision: D75215731 |
|
This pull request has been merged in 6044e01. |
|
This pull request was successfully merged by @huntie in 6044e01 When will my fix make it into a release? | How to file a pick request? |
|
@huntie Sorry to hijack this PR. If that's the case, we are seeing this issue on more components: |
|
@jerone No. Reported error occurs during analysing imports rather than execution of tests. |
mdjastrzebski
pushed a commit
to mdjastrzebski/react-native
that referenced
this pull request
Jun 11, 2025
Summary: Pull Request resolved: facebook#51530 Alternative to facebook#50784. `__mocks__` (and other underscored dirs) are correctly excluded from our npm package via `package.json#files`. But in this instance, this is a source file for the `jest/` directory (Jest preset within `react-native`), and should be included — fix by relocating. Changelog: [General][Fixed] - Fix missing RefreshControlMock source in Jest preset Reviewed By: rshest Differential Revision: D75215731 fbshipit-source-id: 1240344c4236288f31b16513f4df16766ad1e571 # Conflicts: # packages/react-native/jest/setup.js
This was referenced Jun 11, 2025
fabriziocucci
pushed a commit
that referenced
this pull request
Jun 23, 2025
Summary: Pull Request resolved: #51530 Alternative to #50784. `__mocks__` (and other underscored dirs) are correctly excluded from our npm package via `package.json#files`. But in this instance, this is a source file for the `jest/` directory (Jest preset within `react-native`), and should be included — fix by relocating. Changelog: [General][Fixed] - Fix missing RefreshControlMock source in Jest preset Reviewed By: rshest Differential Revision: D75215731 fbshipit-source-id: 1240344c4236288f31b16513f4df16766ad1e571
|
This pull request was successfully merged by @huntie in aeab69a When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Alternative to #50784.
__mocks__(and other underscored dirs) are correctly excluded from our npm package viapackage.json#files. But in this instance, this is a source file for thejest/directory (Jest preset withinreact-native), and should be included — fix by relocating.Changelog:
[General][Fixed] - Fix missing RefreshControlMock source in Jest preset
Reviewed By: rshest
Differential Revision: D75215731