Publish top-level Flow types for react-native
#51908
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add index.js.flow to npm package files for Flow support Currently, the distributed npm package for react-native does not include the index.js.flow file, which causes all exports to be typed as any when using Flow. This commit adds index.js.flow to the "files" array in package.json, ensuring Flow users receive proper type definitions out of the box. This addresses issues where type checking with Flow fails in React Native projects.
facebook-github-bot
added
CLA Signed
|
@robhogan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
robhogan
approved these changes
Jun 9, 2025
There was a problem hiding this comment.
Thanks @aswinandro :)
(Quite rare to see a Flow user outside Meta these days tbh!)
robhogan
changed the title
react-native
|
@robhogan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was successfully merged by @aswinandro in 50667ec When will my fix make it into a release? | How to file a pick request? |
react-native-bot
pushed a commit
that referenced
this pull request
Jun 16, 2025
Summary: FIXED Add index.js.flow to npm package files for Flow support Currently, the distributed npm package for react-native does not include the index.js.flow file, which causes all exports to be typed as any when using Flow. This commit adds index.js.flow to the "files" array in package.json, ensuring Flow users receive proper type definitions out of the box. This addresses issues where type checking with Flow fails in React Native projects. ## Changelog: [General][Added] Publish top-level Flow types for `react-native` Pull Request resolved: #51908 Reviewed By: huntie, necolas Differential Revision: D76292301 Pulled By: robhogan fbshipit-source-id: e56360d3f35af30ef160470181349aac1812e7c1
|
This pull request was successfully merged by @aswinandro in ea6abb6 When will my fix make it into a release? | How to file a pick request? |
buschco
reviewed
Jun 20, 2025
| @@ -81,6 +81,7 @@ | |||
| "gradle.properties", | |||
| "gradle/libs.versions.toml", | |||
| "index.js", | |||
| "index.flow.js", | |||
There was a problem hiding this comment.
I think it should be index.js.flow
There was a problem hiding this comment.
@buschco You're absolutely right, thanks for spotting this. Do you want to open a PR and tag me?
react-native-bot
pushed a commit
that referenced
this pull request
Jun 23, 2025
Summary: FIXED Add index.js.flow to npm package files for Flow support Currently, the distributed npm package for react-native does not include the index.js.flow file, which causes all exports to be typed as any when using Flow. This commit adds index.js.flow to the "files" array in package.json, ensuring Flow users receive proper type definitions out of the box. This addresses issues where type checking with Flow fails in React Native projects. ## Changelog: [General][Added] Publish top-level Flow types for `react-native` Pull Request resolved: #51908 Reviewed By: huntie, necolas Differential Revision: D76292301 Pulled By: robhogan fbshipit-source-id: e56360d3f35af30ef160470181349aac1812e7c1
|
This pull request was successfully merged by @aswinandro in 2cb1f8e When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIXED Add index.js.flow to npm package files for Flow support
Currently, the distributed npm package for react-native does not include the index.js.flow file, which causes all exports to be typed as any when using Flow. This commit adds index.js.flow to the "files" array in package.json, ensuring Flow users receive proper type definitions out of the box. This addresses issues where type checking with Flow fails in React Native projects.
Summary:
Changelog:
[General][Added] Publish top-level Flow types for
react-nativeTest Plan: