[devtools] Allow inspecting cause, name, message, stack of Errors in props #33023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
eps1lon
commented
Apr 25, 2025
| isPathAllowedCheck ? 1 : level + 1, | ||
| ); | ||
|
|
||
| if ('cause' in data) { |
There was a problem hiding this comment.
Will be false if no cause was actually included ('cause' in new Error('test')) but true if it was (even if undefined) ('cause' in new Error('test', { cause: undefined }))
eps1lon
force-pushed
the
sebbie/inspect-errors
branch
from
24ba9b6 to
0c74a7d
Compare
eps1lon
force-pushed
the
sebbie/inspect-errors
branch
from
0c74a7d to
4a61714
Compare
hoxyq
approved these changes
Apr 25, 2025
That worked before already. "Copy to clipboard" is still just an empty object though. |
eps1lon
force-pushed
the
sebbie/inspect-errors
branch
from
4a61714 to
551ce37
Compare
eps1lon
force-pushed
the
sebbie/inspect-errors
branch
from
551ce37 to
3e010ac
Compare
github-actions bot
pushed a commit
to shlomiNugarker/react
that referenced
this pull request
Apr 27, 2025
…props (facebook#33023) DiffTrain build for [c498bfc](facebook@c498bfc)
github-actions bot
pushed a commit
to shlomiNugarker/react
that referenced
this pull request
Apr 27, 2025
…props (facebook#33023) DiffTrain build for [c498bfc](facebook@c498bfc)
jorge-cab
pushed a commit
to jorge-cab/react
that referenced
this pull request
Apr 28, 2025
This was referenced May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
These are not enumerable properties (which is why we ommitted those previously) yet they're still interesting. I feel like for Errors special casing is warranted.
After:
Before:
How did you test this change?