This repository was archived by the owner on Dec 26, 2019. It is now read-only.
Avoid crash for some special XPath queries by explicitly checking whether result nodeSet is empty or not #404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for fast fix! |
facebook-github-bot
added
GH Review: accepted
Import Started
and removed
GH Review: review-needed
labels
|
@marekcirkos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
imurchie
referenced
this pull request
in appium/WebDriverAgent
Nov 16, 2017
dpgraham
pushed a commit
to dpgraham/appium-ios
that referenced
this pull request
Sep 9, 2020
…ther result nodeSet is empty or not Summary: Based on facebookarchive/WebDriverAgent#403 Closes facebookarchive/WebDriverAgent#404 Differential Revision: D4298605 Pulled By: marekcirkos fbshipit-source-id: 44e9d91a26ceac42dc7f20e3ac0188f8013c0771
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #403