-
-
Notifications
You must be signed in to change notification settings - Fork 983
docs: add remarks about external sources #3452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add remarks about external sources #3452
Conversation
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #3452 +/- ##
==========================================
- Coverage 99.97% 99.97% -0.01%
==========================================
Files 2880 2880
Lines 220510 220510
Branches 952 952
==========================================
- Hits 220457 220455 -2
- Misses 53 55 +2
🚀 New features to boost your workflow:
|
@matthewmayer as you are mostly involved in the docs right now, would you like to leave some feedback? |
Do you intend this to be surfaced in the web docs? |
On the long run yes 👍 |
Perhaps add a description of what the tag is used for to https://github.com/faker-js/faker/blob/next/CONTRIBUTING.md#jsdocs |
Good idea, I will try to add that in next few days |
@matthewmayer Added contribution docs and more remarks to the JSDocs (potentially all, but I'm also just a human and might have missed one 😹) |
Co-authored-by: Eric Cheng <[email protected]>
I've added some web facing documentation extensions. ![]() I've also renamed the tag to the singular form "remark" in 627a681. I found it was more reflecting the actual use case and allows the tag to be included multiple times (if so desired). If you do not agree with this change, feel free to bring forward your concerns. |
As we are already not using a standardized tag anyway, these are some really good arguments 👍 |
Do you think this tag would also be appropriate on the faker.internet.email and faker.phone.number methods to indicate that these may generate emails/phone numbers which belong to real people, so one shouldn't send emails or phone numbers to them. I think we mention that elsewhere in the documentation but not directly on these methods. |
I'm not sure if we should do this. Thoughts I have about this are:
however, if others agree with you @matthewmayer, I wont block that decision 🙂 |
This PR introduces a new JSDoc tag we can use to mark methods depending on external resources not in control of FakerJS itself.
I looked up for several possible JSDoc tags and found @remarks to be the one that potentially fits the best. Sadly it is not standardized but at least its listed and used already in some other Projects out there.
ChatGPT also told me after a quick chat that it is one of the best options.