basic support to test against official JSON-Schema-Test-Suite

[StarpTech]

This PR will add basic support to test against the official https://github.com/json-schema-org/JSON-Schema-Test-Suite. It contains only tests for the required feature.

[mcollina]

Good work! Can you add draft 5 and draft 6?

[StarpTech]

It should be added incrementally or what do you mean?

[mcollina]

Would it be hard to just add it to this PR?

[StarpTech]

The required test-case or all JSON files?

[StarpTech]

I added draft 6,7 of the required test-case.

[StarpTech]

@mcollina one important note: I had to add explicitly the type: 'object' property to all schemas otherwise fast-json-stringify will throw undefined unsupported 😥

[StarpTech]

Do we really need to support Node 4 ?

[mcollina]

@mcollina one important note: I had to add explicitly the type: 'object' property to all schemas otherwise fast-json-stringify will throw undefined unsupported 😥 acccording to the spec it should fallback to type object when properties is used.

We should actually behave properly and assume the same, it shouldn't be hard to patch.

Do we really need to support Node 4 ?

We can bump the major without much problems if it's just for the support.

[StarpTech]

We should actually behave properly and assume the same, it shouldn't be hard to patch.

I think it is very hard because we have to handle the any type-case which will make optimizations very complicated. In my opinion it's fine to set some prerequisites in order to build an optimized stringify function this includes to always add the type in your schemas.

e.g

schema

{
    "properties": {
        "foo": {},
        "bar": {}
    },
    "required": ["foo"]
}

this is valid:

{"foo": 1}

json-schema/json-schema#172

[StarpTech]

We can bump the major without much problems if it's just for the support.

Great, I will remove node 4 from the matrix.

[StarpTech]

Please check again I infer type based on the validation keywords.

[mcollina]

Good work, this is fantastic. I've just left a couple of nits.

[mcollina]

can you drop 9 as well?

[mcollina]

I would just use const for these.

[mcollina]

LGTM

[delvedor]

Great work!