Skip to content

Conversation

@pyalex
Copy link
Collaborator

@pyalex pyalex commented Feb 1, 2021

Signed-off-by: Oleksii Moskalenko [email protected]

What this PR does / why we need it:

Latest numpy release (1.20.0) cause issue in pandas -> pyarrow conversion

/usr/local/lib/python3.7/site-packages/pyarrow/pandas_compat.py:588: in dataframe_to_arrays
    for c, f in zip(columns_to_convert, convert_fields)]/usr/local/lib/python3.7/site-packages/_pytest/compat.py:340: PytestDeprecationWarning: The TerminalReporter.writer attribute is deprecated, use TerminalReporter._tw instead at your own risk.
See https://docs.pytest.org/en/stable/deprecations.html#terminalreporter-writer for more information.
  return getattr(object, name, default)
/usr/local/lib/python3.7/site-packages/pyarrow/pandas_compat.py:588: in <listcomp>
    for c, f in zip(columns_to_convert, convert_fields)]
/usr/local/lib/python3.7/site-packages/pyarrow/pandas_compat.py:574: in convert_column
    raise e
/usr/local/lib/python3.7/site-packages/pyarrow/pandas_compat.py:568: in convert_column
    result = pa.array(col, type=type_, from_pandas=True, safe=safe)
pyarrow/array.pxi:292: in pyarrow.lib.array
    ???
pyarrow/array.pxi:83: in pyarrow.lib._ndarray_to_array
    ???
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
>   ???
E   pyarrow.lib.ArrowTypeError: ('Did not pass numpy.dtype object', 'Conversion failed for column datetime with type datetime64[ns, UTC]')
pyarrow/error.pxi:107: ArrowTypeError

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Oleksii Moskalenko <[email protected]>
@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pyalex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot
Copy link
Collaborator

@pyalex: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
test-telemetry b4b1986 link /test test-telemetry

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pyalex pyalex merged commit 01cac48 into feast-dev:master Feb 1, 2021
pyalex added a commit to pyalex/feast that referenced this pull request Feb 1, 2021
Signed-off-by: Oleksii Moskalenko <[email protected]>
pyalex added a commit that referenced this pull request Feb 1, 2021
* Freeze numpy version (#1302)

Signed-off-by: Oleksii Moskalenko <[email protected]>

* bump version

Signed-off-by: Oleksii Moskalenko <[email protected]>

* add changelog

Signed-off-by: Oleksii Moskalenko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants