Skip to content

Conversation

@adchia
Copy link
Collaborator

@adchia adchia commented Aug 4, 2022

What this PR does / why we need it:
This adds a lot more documentation on the Feast Web UI documentation and the release process. Also updates the feast ui bundled UI to always use the latest npm package

Which issue(s) this PR fixes:

Fixes #

@adchia
Copy link
Collaborator Author

adchia commented Aug 4, 2022

cc @AlexEijssen

Signed-off-by: Danny Chiao <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Aug 4, 2022

Codecov Report

Merging #3014 (f4961bf) into master (d4af068) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3014      +/-   ##
==========================================
- Coverage   78.03%   78.01%   -0.02%     
==========================================
  Files         193      193              
  Lines       16446    16445       -1     
==========================================
- Hits        12833    12830       -3     
- Misses       3613     3615       +2     
Flag Coverage Δ
integrationtests 66.90% <ø> (-0.86%) ⬇️
unittests 60.05% <ø> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/infra/online_stores/datastore.py 87.96% <0.00%> (-1.39%) ⬇️
...ests/integration/registration/test_sql_registry.py
sdk/python/tests/unit/test_sql_registry.py 94.05% <0.00%> (ø)
...east/infra/materialization/lambda/lambda_engine.py 93.75% <0.00%> (+1.04%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

adchia added 3 commits August 4, 2022 16:51
Signed-off-by: Danny Chiao <[email protected]>
Signed-off-by: Danny Chiao <[email protected]>
Signed-off-by: Danny Chiao <[email protected]>
Signed-off-by: Danny Chiao <[email protected]>
Copy link
Collaborator

@felixwang9817 felixwang9817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [adchia,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 546ffae into feast-dev:master Aug 4, 2022
adchia added a commit that referenced this pull request Aug 5, 2022
* docs: Add Web UI documentation on repo structure

Signed-off-by: Danny Chiao <[email protected]>

* fix

Signed-off-by: Danny Chiao <[email protected]>

* update release docs

Signed-off-by: Danny Chiao <[email protected]>

* update release docs

Signed-off-by: Danny Chiao <[email protected]>

* remove unnecessary step

Signed-off-by: Danny Chiao <[email protected]>

* fix nits

Signed-off-by: Danny Chiao <[email protected]>
@adchia adchia deleted the UIRelease branch August 5, 2022 20:43
adchia added a commit that referenced this pull request Aug 10, 2022
* docs: Add Web UI documentation on repo structure

Signed-off-by: Danny Chiao <[email protected]>

* fix

Signed-off-by: Danny Chiao <[email protected]>

* update release docs

Signed-off-by: Danny Chiao <[email protected]>

* update release docs

Signed-off-by: Danny Chiao <[email protected]>

* remove unnecessary step

Signed-off-by: Danny Chiao <[email protected]>

* fix nits

Signed-off-by: Danny Chiao <[email protected]>
adchia added a commit that referenced this pull request Aug 10, 2022
* docs: Add Web UI documentation on repo structure

Signed-off-by: Danny Chiao <[email protected]>

* fix

Signed-off-by: Danny Chiao <[email protected]>

* update release docs

Signed-off-by: Danny Chiao <[email protected]>

* update release docs

Signed-off-by: Danny Chiao <[email protected]>

* remove unnecessary step

Signed-off-by: Danny Chiao <[email protected]>

* fix nits

Signed-off-by: Danny Chiao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants