Skip to content

Conversation

@adchia
Copy link
Collaborator

@adchia adchia commented Aug 4, 2022

What this PR does / why we need it:
It now automatically bumps the UI package version, only allows the SDK to release after an npm publish succeeds, and uses an NPM automation token to bypass the 2FA error we used to get with GitHub actions.

It also adds in the feast-feature-server helm chart to the release process (I manually released the helm chart to 0.23.0) so it gets automatically published in the future.
Which issue(s) this PR fixes:

Fixes #

adchia added 4 commits August 4, 2022 16:18
Signed-off-by: Danny Chiao <[email protected]>
Signed-off-by: Danny Chiao <[email protected]>
Signed-off-by: Danny Chiao <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Aug 4, 2022

Codecov Report

Merging #3015 (3e7b760) into master (d4af068) will decrease coverage by 17.98%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #3015       +/-   ##
===========================================
- Coverage   78.03%   60.04%   -17.99%     
===========================================
  Files         193      193               
  Lines       16446    16445        -1     
===========================================
- Hits        12833     9875     -2958     
- Misses       3613     6570     +2957     
Flag Coverage Δ
integrationtests ?
unittests 60.04% <ø> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...sts/integration/registration/test_universal_cli.py 20.20% <0.00%> (-79.80%) ⬇️
...ts/integration/offline_store/test_offline_write.py 26.08% <0.00%> (-73.92%) ⬇️
...fline_store/test_universal_historical_retrieval.py 28.94% <0.00%> (-71.06%) ⬇️
...ests/integration/e2e/test_python_feature_server.py 29.50% <0.00%> (-70.50%) ⬇️
...dk/python/tests/integration/e2e/test_validation.py 27.77% <0.00%> (-69.05%) ⬇️
...s/integration/registration/test_universal_types.py 32.25% <0.00%> (-67.75%) ⬇️
sdk/python/feast/infra/online_stores/redis.py 28.39% <0.00%> (-66.67%) ⬇️
sdk/python/tests/integration/e2e/test_usage_e2e.py 33.87% <0.00%> (-66.13%) ⬇️
sdk/python/tests/data/data_creator.py 34.78% <0.00%> (-65.22%) ⬇️
...n/tests/integration/registration/test_inference.py 35.71% <0.00%> (-64.29%) ⬇️
... and 69 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@felixwang9817
Copy link
Collaborator

/lgtm

Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, adchia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 95be28c into feast-dev:master Aug 4, 2022
adchia added a commit that referenced this pull request Aug 5, 2022
…rver helm chart to release (#3015)

* ci: Update feast-feature-server helm chart to be automatically released in each Feast version

Signed-off-by: Danny Chiao <[email protected]>

* update files to bump

Signed-off-by: Danny Chiao <[email protected]>

* update ui automation

Signed-off-by: Danny Chiao <[email protected]>

* update ui automation

Signed-off-by: Danny Chiao <[email protected]>
@adchia adchia deleted the automateUIRelease branch August 5, 2022 20:43
adchia added a commit that referenced this pull request Aug 10, 2022
…rver helm chart to release (#3015)

* ci: Update feast-feature-server helm chart to be automatically released in each Feast version

Signed-off-by: Danny Chiao <[email protected]>

* update files to bump

Signed-off-by: Danny Chiao <[email protected]>

* update ui automation

Signed-off-by: Danny Chiao <[email protected]>

* update ui automation

Signed-off-by: Danny Chiao <[email protected]>
adchia added a commit that referenced this pull request Aug 10, 2022
…rver helm chart to release (#3015)

* ci: Update feast-feature-server helm chart to be automatically released in each Feast version

Signed-off-by: Danny Chiao <[email protected]>

* update files to bump

Signed-off-by: Danny Chiao <[email protected]>

* update ui automation

Signed-off-by: Danny Chiao <[email protected]>

* update ui automation

Signed-off-by: Danny Chiao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants