Skip to content

Conversation

@adchia
Copy link
Collaborator

@adchia adchia commented Aug 7, 2022

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Signed-off-by: Danny Chiao <[email protected]>
Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, adchia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

codecov-commenter commented Aug 7, 2022

Codecov Report

Merging #3030 (113e892) into master (fe9a0bd) will increase coverage by 9.97%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3030      +/-   ##
==========================================
+ Coverage   67.72%   77.69%   +9.97%     
==========================================
  Files         167      194      +27     
  Lines       14678    16097    +1419     
==========================================
+ Hits         9940    12507    +2567     
+ Misses       4738     3590    -1148     
Flag Coverage Δ
integrationtests 67.57% <100.00%> (-0.15%) ⬇️
unittests 59.35% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/usage.py 91.57% <100.00%> (+8.51%) ⬆️
...ores/contrib/trino_offline_store/trino_type_map.py 6.66% <0.00%> (ø)
...ffline_stores/contrib/trino_offline_store/trino.py 8.72% <0.00%> (ø)
.../online_stores/contrib/hbase_repo_configuration.py 100.00% <0.00%> (ø)
...s/contrib/trino_offline_store/tests/data_source.py 17.64% <0.00%> (ø)
...s/contrib/trino_offline_store/connectors/upload.py 8.97% <0.00%> (ø)
...s/contrib/postgres_offline_store/tests/__init__.py 100.00% <0.00%> (ø)
sdk/python/feast/transformation_server.py 40.47% <0.00%> (ø)
...tores/contrib/trino_offline_store/trino_queries.py 15.05% <0.00%> (ø)
...offline_stores/contrib/spark_repo_configuration.py 100.00% <0.00%> (ø)
... and 91 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@adchia adchia merged commit dea65e4 into feast-dev:master Aug 7, 2022
@adchia adchia deleted the fixUsage branch August 7, 2022 17:04
adchia added a commit that referenced this pull request Aug 10, 2022
adchia added a commit that referenced this pull request Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants