-
Notifications
You must be signed in to change notification settings - Fork 1.2k
chore: Add types hints and set created_timestamp in sql registry #3033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Achal Shah <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #3033 +/- ##
==========================================
+ Coverage 67.72% 77.64% +9.92%
==========================================
Files 167 194 +27
Lines 14679 16114 +1435
==========================================
+ Hits 9941 12512 +2571
+ Misses 4738 3602 -1136
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Achal Shah <[email protected]>
felixwang9817
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, felixwang9817 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* chore: Add types for some methods in the sql registry Signed-off-by: Achal Shah <[email protected]> * created_timestamp Signed-off-by: Achal Shah <[email protected]>
* chore: Add types for some methods in the sql registry Signed-off-by: Achal Shah <[email protected]> * created_timestamp Signed-off-by: Achal Shah <[email protected]>
Signed-off-by: Achal Shah [email protected]
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #