Skip to content

Conversation

@achals
Copy link
Member

@achals achals commented Aug 8, 2022

Signed-off-by: Achal Shah [email protected]

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

@codecov-commenter
Copy link

codecov-commenter commented Aug 8, 2022

Codecov Report

Merging #3033 (7f8d7bb) into master (4bba787) will increase coverage by 9.92%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3033      +/-   ##
==========================================
+ Coverage   67.72%   77.64%   +9.92%     
==========================================
  Files         167      194      +27     
  Lines       14679    16114    +1435     
==========================================
+ Hits         9941    12512    +2571     
+ Misses       4738     3602    -1136     
Flag Coverage Δ
integrationtests 67.49% <0.00%> (-0.23%) ⬇️
unittests 59.33% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/infra/registry_stores/sql.py 72.75% <100.00%> (+39.87%) ⬆️
sdk/python/tests/unit/test_sql_registry.py 94.11% <100.00%> (+68.71%) ⬆️
...python/feast/infra/offline_stores/offline_store.py 83.00% <0.00%> (-1.54%) ⬇️
sdk/python/tests/utils/e2e_test_validation.py 88.88% <0.00%> (ø)
sdk/python/tests/integration/e2e/test_usage_e2e.py 100.00% <0.00%> (ø)
...n/tests/integration/materialization/test_lambda.py 100.00% <0.00%> (ø)
...n/tests/integration/registration/test_inference.py 100.00% <0.00%> (ø)
...sts/integration/registration/test_feature_store.py 100.00% <0.00%> (ø)
...ts/integration/feature_repos/repo_configuration.py 86.51% <0.00%> (ø)
sdk/python/feast/transformation_server.py 40.47% <0.00%> (ø)
... and 100 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Achal Shah <[email protected]>
@achals achals changed the title chore: Add types for some methods in the sql registry chore: Add types for some methods in the sql registry and set created_timestamp Aug 8, 2022
@achals achals changed the title chore: Add types for some methods in the sql registry and set created_timestamp chore: Add types hints and set created_timestamp in sql registry Aug 8, 2022
Copy link
Collaborator

@felixwang9817 felixwang9817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [achals,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 63d541d into feast-dev:master Aug 8, 2022
@achals achals deleted the achal/infra-types branch August 9, 2022 20:57
adchia pushed a commit that referenced this pull request Aug 10, 2022
* chore: Add types for some methods in the sql registry

Signed-off-by: Achal Shah <[email protected]>

* created_timestamp

Signed-off-by: Achal Shah <[email protected]>
adchia pushed a commit that referenced this pull request Aug 10, 2022
* chore: Add types for some methods in the sql registry

Signed-off-by: Achal Shah <[email protected]>

* created_timestamp

Signed-off-by: Achal Shah <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants