Skip to content

Conversation

@adchia
Copy link
Collaborator

@adchia adchia commented Oct 6, 2022

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Signed-off-by: Danny Chiao <[email protected]>
adchia added 3 commits October 6, 2022 00:54
Signed-off-by: Danny Chiao <[email protected]>
Signed-off-by: Danny Chiao <[email protected]>
Signed-off-by: Danny Chiao <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2022

Codecov Report

Base: 67.53% // Head: 76.80% // Increases project coverage by +9.27% 🎉

Coverage data is based on head (5a407d9) compared to base (eff01d1).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3273      +/-   ##
==========================================
+ Coverage   67.53%   76.80%   +9.27%     
==========================================
  Files         181      218      +37     
  Lines       16514    18436    +1922     
==========================================
+ Hits        11152    14160    +3008     
+ Misses       5362     4276    -1086     
Flag Coverage Δ
integrationtests 67.53% <ø> (+<0.01%) ⬆️
unittests 57.95% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../python/feast/infra/feature_servers/base_config.py 100.00% <0.00%> (ø)
...n/feast/infra/feature_servers/aws_lambda/config.py 100.00% <0.00%> (ø)
.../contrib/postgres_offline_store/postgres_source.py 50.66% <0.00%> (ø)
sdk/python/feast/infra/utils/hbase_utils.py 41.17% <0.00%> (ø)
...s/contrib/trino_offline_store/tests/data_source.py 17.64% <0.00%> (ø)
...s/contrib/trino_offline_store/connectors/upload.py 8.97% <0.00%> (ø)
...stores/contrib/trino_offline_store/trino_source.py 5.37% <0.00%> (ø)
...ine_stores/contrib/cassandra_repo_configuration.py 100.00% <0.00%> (ø)
...hon/feast/infra/utils/postgres/connection_utils.py 48.00% <0.00%> (ø)
sdk/python/feast/loaders/yaml.py 18.18% <0.00%> (ø)
... and 111 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

adchia added 2 commits October 6, 2022 01:30
Signed-off-by: Danny Chiao <[email protected]>
Signed-off-by: Danny Chiao <[email protected]>
@feast-ci-bot feast-ci-bot added size/L and removed size/M labels Oct 6, 2022
adchia added 2 commits October 6, 2022 01:35
Signed-off-by: Danny Chiao <[email protected]>
Signed-off-by: Danny Chiao <[email protected]>
@jerive jerive mentioned this pull request Oct 6, 2022
@kevjumba
Copy link
Collaborator

kevjumba commented Oct 6, 2022

/lgtm

@kevjumba kevjumba merged commit a84ace0 into feast-dev:master Oct 6, 2022
@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, jerive, kevjumba

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

kevjumba pushed a commit to kevjumba/feast that referenced this pull request Oct 6, 2022
* ci: Fix Feast UI tests

Signed-off-by: Danny Chiao <[email protected]>

* add test to workflow

Signed-off-by: Danny Chiao <[email protected]>

* add test to workflow

Signed-off-by: Danny Chiao <[email protected]>

* fix test suite in workflow

Signed-off-by: Danny Chiao <[email protected]>

* fix README

Signed-off-by: Danny Chiao <[email protected]>

* fix build

Signed-off-by: Danny Chiao <[email protected]>

* fix test name

Signed-off-by: Danny Chiao <[email protected]>

* upgrade caniuse

Signed-off-by: Danny Chiao <[email protected]>

Signed-off-by: Danny Chiao <[email protected]>
franciscojavierarceo pushed a commit to franciscojavierarceo/feast that referenced this pull request Oct 18, 2022
* ci: Fix Feast UI tests

Signed-off-by: Danny Chiao <[email protected]>

* add test to workflow

Signed-off-by: Danny Chiao <[email protected]>

* add test to workflow

Signed-off-by: Danny Chiao <[email protected]>

* fix test suite in workflow

Signed-off-by: Danny Chiao <[email protected]>

* fix README

Signed-off-by: Danny Chiao <[email protected]>

* fix build

Signed-off-by: Danny Chiao <[email protected]>

* fix test name

Signed-off-by: Danny Chiao <[email protected]>

* upgrade caniuse

Signed-off-by: Danny Chiao <[email protected]>

Signed-off-by: Danny Chiao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants