Skip to content

fix: Read project data from the 'projects' key while loading the registry state in the Feast UI #4772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
redhatHameed merged 3 commits into from
Jan 21, 2025
Merged

fix: Read project data from the 'projects' key while loading the registry state in the Feast UI #4772

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
98b02c0
fix: Read project data from the 'projects' key while loading the regi…
boliri Nov 20, 2024
c5d0dff
fix: regenerate registry file so that UI tests can parse the 'project…
boliri Nov 20, 2024
c0f6f93
fix: Check for non-null and non-undefined spec of a project to mitiga…
boliri Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified ui/public/registry.db
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion ui/src/FeastUISansProviders.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ test("full app rendering", async () => {
expect(screen.getByText(/Explore this Project/i)).toBeInTheDocument();

const projectNameRegExp = new RegExp(
parsedRegistry.projectMetadata[0].project!,
parsedRegistry.projects[0].spec?.name!,
"i"
);

Expand Down
2 changes: 1 addition & 1 deletion ui/src/queries/useLoadRegistry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ const useLoadRegistry = (url: string) => {
// });

return {
project: objects.projectMetadata[0].project!,
project: objects.projects[0].spec?.name!,
objects,
mergedFVMap,
mergedFVList,
Expand Down
Loading