Skip to content

feat: Add milvus package to release image & option to Operator #4870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
franciscojavierarceo merged 1 commit into from
Dec 30, 2024
Merged

feat: Add milvus package to release image & option to Operator #4870

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion infra/feast-operator/api/v1alpha1/featurestore_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ type OnlineStoreFilePersistence struct {

// OnlineStoreDBStorePersistence configures the DB store persistence for the offline store service
type OnlineStoreDBStorePersistence struct {
// +kubebuilder:validation:Enum=snowflake.online;redis;ikv;datastore;dynamodb;bigtable;postgres;cassandra;mysql;hazelcast;singlestore;hbase;elasticsearch;qdrant;couchbase
// +kubebuilder:validation:Enum=snowflake.online;redis;ikv;datastore;dynamodb;bigtable;postgres;cassandra;mysql;hazelcast;singlestore;hbase;elasticsearch;qdrant;couchbase;milvus
Type string `json:"type"`
// Data store parameters should be placed as-is from the "feature_store.yaml" under the secret key. "registry_type" & "type" fields should be removed.
SecretRef corev1.LocalObjectReference `json:"secretRef"`
Expand All @@ -178,6 +178,7 @@ var ValidOnlineStoreDBStorePersistenceTypes = []string{
"elasticsearch",
"qdrant",
"couchbase",
"milvus",
}

// LocalRegistryConfig configures the deployed registry service
Expand Down
2 changes: 2 additions & 0 deletions infra/feast-operator/config/crd/bases/feast.dev_featurestores.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -749,6 +749,7 @@ spec:
- elasticsearch
- qdrant
- couchbase
- milvus
type: string
required:
- secretRef
Expand Down Expand Up @@ -2020,6 +2021,7 @@ spec:
- elasticsearch
- qdrant
- couchbase
- milvus
type: string
required:
- secretRef
Expand Down
2 changes: 2 additions & 0 deletions infra/feast-operator/dist/install.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -757,6 +757,7 @@ spec:
- elasticsearch
- qdrant
- couchbase
- milvus
type: string
required:
- secretRef
Expand Down Expand Up @@ -2028,6 +2029,7 @@ spec:
- elasticsearch
- qdrant
- couchbase
- milvus
type: string
required:
- secretRef
Expand Down
2 changes: 1 addition & 1 deletion sdk/python/feast/infra/feature_servers/multicloud/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
FROM python:3.11-slim-bullseye

RUN pip install --no-cache-dir pip --upgrade
RUN pip install --no-cache-dir "feast[aws,gcp,snowflake,redis,go,mysql,postgres,opentelemetry,grpcio,k8s,duckdb]"
RUN pip install --no-cache-dir "feast[aws,gcp,snowflake,redis,go,mysql,postgres,opentelemetry,grpcio,k8s,duckdb,milvus]"


RUN apt update && apt install -y -V ca-certificates lsb-release wget && \
Expand Down
Loading