fix(docs-i18n-ru/en): fix crash on "header" stage in tutorial; #668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correct: https://github.com/feature-sliced/tutorial-conduit/blob/main/shared/api/auth.server.ts#L51 No correct: [EN]:https://github.com/feature-sliced/documentation/blob/master/i18n/en/docusaurus-plugin-content-docs/current/get-started/tutorial.md?plain=1#L830 [RU]:https://github.com/feature-sliced/documentation/blob/master/i18n/ru/docusaurus-plugin-content-docs/current/get-started/tutorial.md?plain=1#L827
👷 Deploy request for pr-fsd pending review.Visit the deploys page to approve it
|
illright
approved these changes
May 6, 2024
Member
illright
left a comment
illright
left a comment
There was a problem hiding this comment.
Спасибо за очень подробный репорт! Все верно, это ошибка в тексте туториала. Видимо, в какой-то момент я заметил, что приложение падает, исправил, а в тексте исправить забыл
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Привет 👋
Correct: https://github.com/feature-sliced/tutorial-conduit/blob/main/shared/api/auth.server.ts#L51
No correct: EN, RU
Changelog
Мотивация:
Строгое следование туториалу (код и структура приложения используется из примеров), приводит приложение к крашу по завершению этапа с созданием хедара приложения.
Причина:
Проблема заключается в предыдущем этапе, а точнее в примере, где пропустили оператор нулевого слияния (EN, RU).
Решение:
Добавил пропущенный оператор, приведя строк к виду, как в эталонном репозитории, код которого должен совпадать(в теории) с кодом приложения по окончанию туториала.
https://github.com/feature-sliced/tutorial-conduit/blob/main/shared/api/auth.server.ts#L51
Возможно я что-то упустил и Вы можете предложить свое решение проблемы на этапе с хедером.