Skip to content

Feature: Middle click sidebar item to open new tab #13639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 2, 2023
Merged

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Nov 1, 2023

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Feature: Open New Tab with Middle Click over Navigation Pane item #13410

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Middle click sidebar item
    2. Confirm it opens in a new tab
    3. Hold down ctrl key and click sidebar item
    4. Confirm it opens in a new tab
    5. Select sidebar item via keyboard and press enter key
    6. Confirm it opens the item in the same tab

Screenshots (optional)
Add screenshots here.

@yaira2 yaira2 force-pushed the ya/MiddleClickSidebar branch from f3b0366 to 9c7429d Compare November 1, 2023 20:50
@yaira2 yaira2 changed the title Middle click sidebar item to open new tab Feature: Middle click sidebar item to open new tab Nov 1, 2023
@yaira2 yaira2 requested review from hishitetsu and marcelwgn and removed request for hishitetsu November 2, 2023 14:08
Copy link
Member

@hishitetsu hishitetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Nov 2, 2023
@yaira2 yaira2 merged commit 8c888f3 into main Nov 2, 2023
@yaira2 yaira2 deleted the ya/MiddleClickSidebar branch November 2, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Open New Tab with Middle Click over Navigation Pane item
2 participants