Skip to content

Remember the sort option and direction across multiple sessions #1439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 15, 2020
Merged

Remember the sort option and direction across multiple sessions #1439

merged 8 commits into from
Jul 15, 2020

Conversation

jaigak
Copy link
Contributor

@jaigak jaigak commented Jul 14, 2020 •
edited
Loading

Fixes #1327

@ghost ghost added the needs - code review label Jul 14, 2020
@yaira2 yaira2 requested review from yaira2, lukeblevins and tsvietOK and removed request for yaira2 and lukeblevins July 14, 2020 18:32
lukeblevins
lukeblevins approved these changes Jul 14, 2020
View reviewed changes
Copy link
Contributor

@lukeblevins lukeblevins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

@yaira2
Copy link
Member

yaira2 commented Jul 14, 2020

@Jaiganeshkumaran Would it be possible to store the layout setting as well?

tsvietOK
tsvietOK suggested changes Jul 15, 2020
View reviewed changes
Copy link
Contributor

@tsvietOK tsvietOK left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
There is a bug, when trying to open app first time after this patch.

yaira2
yaira2 reviewed Jul 15, 2020
View reviewed changes
@jaigak
Copy link
Contributor Author

jaigak commented Jul 15, 2020

There is a bug, when trying to open app first time after this patch.

This issue has been fixed.

@jaigak
Copy link
Contributor Author

jaigak commented Jul 15, 2020

@Jaiganeshkumaran Would it be possible to store the layout setting as well?

Isn't the layout mode stored already?

@yaira2 yaira2 changed the title Remember sort option and direction Remember sort option and direction across app instances Jul 15, 2020
@yaira2 yaira2 changed the title Remember sort option and direction across app instances Remember sort option and direction across multiple sessions Jul 15, 2020
@yaira2 yaira2 changed the title Remember sort option and direction across multiple sessions Remember the sort option and direction across multiple sessions Jul 15, 2020
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Jul 15, 2020
@yaira2 yaira2 requested a review from tsvietOK July 15, 2020 22:52
@yaira2 yaira2 merged commit 6b7330a into files-community:master Jul 15, 2020
@jaigak jaigak deleted the sort branch July 16, 2020 03:03
@gave92 gave92 mentioned this pull request Feb 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukeblevins lukeblevins lukeblevins approved these changes

@tsvietOK tsvietOK tsvietOK approved these changes

@yaira2 yaira2 yaira2 approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sorting always reset on app close
4 participants
@jaigak @yaira2 @lukeblevins @tsvietOK