Skip to content

Code Quality: Wrap InvokeVerb inside STA #17092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 4, 2025

Conversation

ChengYi0224
Copy link
Contributor

Description
Wraps InvokeVerb in an STA thread to fix COM threading issues when unpinning folders from sidebar. Ensures stable shell verb invocation while maintaining UI responsiveness.

Test Steps
Verified unpinning stability by:

  1. Launching Files
  2. Right-clicking pinned folders
  3. Selecting "Unpin from Sidebar"
  4. Confirming:
    • Immediate removal from Pinned section
    • No UI freezing
    • No errors in debug output

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label May 4, 2025
@yaira2 yaira2 requested a review from 0x5bfa May 4, 2025 14:48
Copy link
Member

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This codebase is not AoT safe so thisll be soon retired FYI.

@yaira2 yaira2 merged commit 4298e71 into files-community:main May 4, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants