Skip to content

Appcenter fixes #2663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Dec 22, 2020
Merged

Appcenter fixes #2663

merged 11 commits into from
Dec 22, 2020

Conversation

gave92
Copy link
Member

@gave92 gave92 commented Dec 22, 2020

Fixes #2652

This PR fixes a few crashing bugs that were detected by AppCenter for version 0.23.
Each commit fixes a specific appcenter issue, the commit name is the appcenter error number.
These has been lumped in a single PR since they are mostly one-line fixes/exception handling, let me know if this is acceptable or if should I open a PR for each of them.

6e99d4f / 681497578u
Fixes an issue where the app crashes when updating the jump list

376cfbd / 1346245124u
Fixes an issue where the app crashes when navigating up

462aad7 / 2134525649u
Fixes an issue where the app crashes when tapping on an item in the About settings page

cf476b0 / 1407639912u
Fixes an issue where the app crashes when opening file properties on Windows 1803

30362e7 / 1782844498u
Fixes an issue where the app crashes when undoing a copy operation

0f26b5e / 4140837726u
Fixes an issue where the app crashes when right clicking on the recyclebin sidebar item

c9530b6 / 661635400u
Fixes an issue where the app crashes when opening the context menu

c9530b6 / 470478233u
Fixes an issue where the app crashes due to an FileNotFoundException during file enumeration

62e84a6 / 2753013842u
Fixes an issue where the app crashes on startup (#2652)

d06d3dc / 2511593153u
Fixes an issue where the app crashes due to an ObjectDisposedException during file enumeration

6de25a4 / 3301491942u
Fixes an issue where the app crashes due to an NotImplementedException during file enumeration

@yaira2
Copy link
Member

yaira2 commented Dec 22, 2020

These has been lumped in a single PR since they are mostly one-line fixes/exception handling, let me know if this is acceptable or if should I open a PR for each of them.

@gave92 This is more than fine 😄

@gave92 gave92 marked this pull request as ready for review December 22, 2020 19:27
@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Dec 22, 2020
@yaira2 yaira2 merged commit bc0b214 into files-community:master Dec 22, 2020
@gave92 gave92 deleted the appcenter_fixes branch December 22, 2020 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Files crash on startup after updating to 0.22.5
2 participants