Skip to content

Adding onSnapshotsInSync (not public) #778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 10, 2019
Merged

Adding onSnapshotsInSync (not public) #778

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a93d284
passing integration tests, still need spec tests
Sep 9, 2019
f45182b
add spec tests
Sep 9, 2019
a49fc97
Add activity paramter
Sep 9, 2019
555bce6
update unit test
Sep 10, 2019
6c619da
resolve michael comments
Sep 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update unit test
  • Loading branch information
Brian Chen committed Sep 10, 2019
commit 555bce6042680e8a551371fd74991d311a86a6f9
6 changes: 5 additions & 1 deletion firebase-firestore/src/test/java/com/google/firebase/firestore/core/EventManagerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,11 @@ public void testWillForwardOnOnlineStateChangedCalls() {

QueryListener spy = mock(QueryListener.class);
when(spy.getQuery()).thenReturn(query1);
doAnswer(invocation -> events.add(invocation.getArguments()[0]))
doAnswer(
invocation -> {
events.add(invocation.getArguments()[0]);
return false;
})
.when(spy)
.onOnlineStateChanged(any());

Expand Down