Skip to content

add bloomFilter to proto #10823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 16, 2023
Merged

Conversation

milaGGL
Copy link
Contributor

@milaGGL milaGGL commented Feb 15, 2023

#no-changelog

Add bloom filter to protos.

Ported from web SDK: https://github.com/firebase/firebase-js-sdk/pull/6780/files
Similar to android SDK: firebase/firebase-android-sdk#4564

@milaGGL milaGGL requested a review from dconeybe February 15, 2023 20:59
Copy link
Contributor

@dconeybe dconeybe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Kudos for figuring this out on your own :)

@milaGGL milaGGL merged commit ca6f7d2 into mila/BloomFilter Feb 16, 2023
@milaGGL milaGGL deleted the mila/BloomFilter-update-proto branch February 16, 2023 05:52
@firebase firebase locked and limited conversation to collaborators Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants