Skip to content

Split GoogleUtilities from FirebaseCore #1370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 49 commits into from
Jul 6, 2018
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
49 commits
Select commit Hold shift + click to select a range
03676a5
Split FirebaseUtilities from FirebaseCore
paulb777 Jun 2, 2018
22f72f8
Utilities minimum version to 6.0
paulb777 Jun 2, 2018
d9c9a08
Rename FirebaseUtilities to GoogleUtilities
paulb777 Jun 21, 2018
958cde6
style
paulb777 Jun 21, 2018
c06da6c
WIP - restore FIRLogger as a wrapper to GULLogger - pass Core unit tests
paulb777 Jun 23, 2018
3c2c4a6
style
paulb777 Jun 23, 2018
001a21f
checkpoint
paulb777 Jun 23, 2018
94be7d2
temporary Environment wrapper
paulb777 Jun 23, 2018
9509e41
checkpoint
paulb777 Jun 26, 2018
49c1f64
WIP Checkpoint - Core and Auth unit tests
paulb777 Jun 26, 2018
ef909e2
WIP checkpoint - all Firebase unit tests
paulb777 Jun 26, 2018
253e4bf
style
paulb777 Jun 26, 2018
cb29d53
Restore Firestore
paulb777 Jun 26, 2018
23e830c
WIP Access GoogleUtilities for Firestore
paulb777 Jun 27, 2018
96c7363
WIP Access GoogleUtilities for Firestore
paulb777 Jun 27, 2018
ca7ca3e
renames
paulb777 Jun 27, 2018
ea4d3f2
Force GoogleUtilities to link with FirebaseCore in cmake
paulb777 Jun 27, 2018
ab81c54
style
paulb777 Jun 27, 2018
abf110c
Try again with GoogleUtilities
paulb777 Jun 28, 2018
f1bfad2
disable failing FIRLogger tests
paulb777 Jun 28, 2018
6562098
style
paulb777 Jun 28, 2018
bedc87a
fix typo
paulb777 Jun 28, 2018
0e3e504
one more loggertest disable
paulb777 Jun 28, 2018
ed43b69
Don't integrate Analytics into unit tests
paulb777 Jun 28, 2018
dc9e6f0
Remove wrappers that were only for Analytics linking
paulb777 Jun 28, 2018
fe777a9
Split Reachability from Networking - part 1
paulb777 Jun 28, 2018
3b83363
Use local GoogleUtilities in Firestore unit testing
paulb777 Jun 28, 2018
fd568e0
Replace GoogleToolboxForMac with a GoogleUtilities subspec
paulb777 Jun 28, 2018
11ed49f
pod deintegrate
paulb777 Jun 28, 2018
e8fd9e7
style and podspec fix
paulb777 Jun 28, 2018
e1555da
fix bad merge
paulb777 Jun 28, 2018
ce59ba2
macOS and tvOS Core tests now need to force category loading
paulb777 Jun 29, 2018
6d49931
Option on app not tests
paulb777 Jun 29, 2018
e022441
clean up
paulb777 Jun 29, 2018
970f8c3
podspec cleanup
paulb777 Jun 29, 2018
739e6c0
address review feedback
paulb777 Jun 30, 2018
a123f6e
Fix bad rebase merge
paulb777 Jun 30, 2018
9c8f282
Update GoogleUtilities version
paulb777 Jun 30, 2018
74d74bf
style
paulb777 Jun 30, 2018
4bc7166
podspec consistency
paulb777 Jun 30, 2018
640550b
Add missing Security framework for SecTrustEvaluate API call
paulb777 Jul 1, 2018
df4c242
Consistently use module reference for public/private headers
paulb777 Jul 1, 2018
bce3438
delete unnecessary import
paulb777 Jul 1, 2018
aa2f13f
consistency
paulb777 Jul 1, 2018
1592bf9
Add library dependency
paulb777 Jul 2, 2018
9c26db1
GoogleUtilities does not have to be static - let Podfile determine
paulb777 Jul 2, 2018
988aee0
Fix non-modular import error
paulb777 Jul 2, 2018
c2e9973
fix analytics tests
paulb777 Jul 3, 2018
aeb878b
review updates
paulb777 Jul 6, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
podspec consistency
  • Loading branch information
paulb777 committed Jun 30, 2018
commit 4bc7166838a767c4c80a9fc7393e80f8c00feedb
1 change: 0 additions & 1 deletion FirebaseAuth.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,5 @@ supports email and password accounts, as well as several 3rd party authenticatio
s.framework = 'Security'
s.dependency 'FirebaseCore', '~> 5.0'
s.dependency 'GoogleUtilities/Environment', '~> 5.0'
s.dependency 'GoogleUtilities/Logger', '~> 5.0'
s.dependency 'GTMSessionFetcher/Core', '~> 1.1'
end
2 changes: 1 addition & 1 deletion FirebaseCore.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ Firebase Core includes FIRApp and FIROptions which provide central configuration
s.prefix_header_file = false

s.source_files = 'Firebase/Core/**/*.[mh]'
s.public_header_files = 'Firebase/Core/Public/*.h'
s.public_header_files = 'Firebase/Core/Public/*.h', 'Firebase/Core/Private/*.h'
s.private_header_files = 'Firebase/Core/Private/*.h'
s.frameworks = [
'Foundation'
Expand Down
1 change: 0 additions & 1 deletion FirebaseFirestore.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ Google Cloud Firestore is a NoSQL document database built for automatic scaling,
s.public_header_files = 'Firestore/Source/Public/*.h'

s.dependency 'FirebaseCore', '~> 5.0'
s.dependency 'GoogleUtilities/Logger', '~> 5.0'
s.dependency 'gRPC-ProtoRPC', '~> 1.0'
s.dependency 'leveldb-library', '~> 1.18'
s.dependency 'Protobuf', '~> 3.1'
Expand Down