Fix Remote Config pre-configure access. #9551
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, when `RemoteConfig.remoteConfig()` is called before `FirebaseApp.configure()` is called, Similar to Database, AppCheck, and others we'll now throw an ObjC exception. We're not going to make it nullable or throw a Swift compatible error since it'd affect the callsite of every usage (either a `?` or `try`) and this is deemed a programming error: `configure()` has to be called first. Fixes #8640
karenyz
approved these changes
Mar 31, 2022
paulb777
approved these changes
Mar 31, 2022
| [NSException raise:@"FIRAppNotConfigured" | ||
| format:@"The default `FirebaseApp` instance must be configured before the " | ||
| @"default Remote Config instance can be initialized. One way to ensure this " | ||
| @"is to call `FirebaseApp.configure()` in the App Delegate's " |
There was a problem hiding this comment.
nit: Should AppDelegate be unspaced?
There was a problem hiding this comment.
This is consistent with the other products, I guess it's a hybrid of Apple's (they have a space but non capitalized, or no space and capitalized) https://developer.apple.com/documentation/uikit/uiapplicationdelegate.
Can change if you feel strongly about it but thought I'd keep it for consistency
There was a problem hiding this comment.
Going to merge, will follow up on another PR if you think it's worth changing.
There was a problem hiding this comment.
SGTM - not a strong view and I trust your judgement
paulb777
pushed a commit
that referenced
this pull request
Apr 4, 2022
* Fix Remote Config pre-configure access. Currently, when `RemoteConfig.remoteConfig()` is called before `FirebaseApp.configure()` is called, Similar to Database, AppCheck, and others we'll now throw an ObjC exception. We're not going to make it nullable or throw a Swift compatible error since it'd affect the callsite of every usage (either a `?` or `try`) and this is deemed a programming error: `configure()` has to be called first. Fixes #8640 * CHANGELOG
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when
RemoteConfig.remoteConfig()is called beforeFirebaseApp.configure()is called, Similar to Database, AppCheck, andothers we'll now throw an ObjC exception. We're not going to make it
nullable or throw a Swift compatible error since it'd affect the
callsite of every usage (either a
?ortry) and this is deemed aprogramming error:
configure()has to be called first.Fixes #8640