Skip to content

feat: Add support for new Firestore types #8994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

ehsannas
Copy link
Contributor

@ehsannas ehsannas commented May 2, 2025

Adds support for MinKey, MaxKey, RegexValue, Int32Value, BsonObjectId, BsonTimestamp, and BsonBinaryData.

@ehsannas ehsannas requested review from a team as code owners May 2, 2025 21:55
Copy link

changeset-bot bot commented May 2, 2025

🦋 Changeset detected

Latest commit: cbba951

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/firestore Minor
firebase Patch
@firebase/firestore-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented May 2, 2025

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_vertexai_responses.sh should be updated to clone the latest version of the responses: v11.1

@ehsannas ehsannas requested a review from a team as a code owner May 2, 2025 22:07
@ehsannas
Copy link
Contributor Author

ehsannas commented May 2, 2025

@milaGGL please take a look, sanity check the PR, and handle the remaining TODOs where possible.

Copy link
Contributor

github-actions bot commented May 2, 2025

Changeset File Check ⚠️

  • Package @firebase/firestore has a minor bump which requires an additional line to bump the main "firebase" package to minor.

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • @firebase/firestore

    TypeBase (080a90d)Merge (b00ffbd)Diff
    browser385 kB396 kB+11.5 kB (+3.0%)
    main595 kB614 kB+19.0 kB (+3.2%)
    module385 kB396 kB+11.5 kB (+3.0%)
    react-native385 kB396 kB+11.5 kB (+3.0%)
  • @firebase/firestore-lite

    TypeBase (080a90d)Merge (b00ffbd)Diff
    browser114 kB123 kB+9.43 kB (+8.3%)
    main157 kB171 kB+14.1 kB (+9.0%)
    module114 kB123 kB+9.43 kB (+8.3%)
    react-native114 kB124 kB+9.43 kB (+8.3%)
  • bundle

    15 size changes

    TypeBase (080a90d)Merge (b00ffbd)Diff
    firestore (CSI Auto Indexing Disable and Delete)275 kB280 kB+5.31 kB (+1.9%)
    firestore (CSI Auto Indexing Enable)275 kB280 kB+5.31 kB (+1.9%)
    firestore (Persistence)306 kB311 kB+5.27 kB (+1.7%)
    firestore (Query Cursors)252 kB260 kB+8.15 kB (+3.2%)
    firestore (Query)249 kB258 kB+8.15 kB (+3.3%)
    firestore (Read data once)237 kB244 kB+6.82 kB (+2.9%)
    firestore (Read Write w Persistence)331 kB340 kB+9.78 kB (+3.0%)
    firestore (Realtime updates)239 kB246 kB+6.82 kB (+2.8%)
    firestore (Transaction)216 kB224 kB+7.87 kB (+3.6%)
    firestore (Write data)216 kB222 kB+5.97 kB (+2.8%)
    firestore-lite (Query Cursors)105 kB113 kB+8.05 kB (+7.7%)
    firestore-lite (Query)101 kB109 kB+8.05 kB (+8.0%)
    firestore-lite (Read data once)76.3 kB83.1 kB+6.81 kB (+8.9%)
    firestore-lite (Transaction)102 kB110 kB+7.90 kB (+7.8%)
    firestore-lite (Write data)85.9 kB91.6 kB+5.70 kB (+6.6%)

  • firebase

    TypeBase (080a90d)Merge (b00ffbd)Diff
    firebase-compat.js797 kB806 kB+8.45 kB (+1.1%)
    firebase-firestore-compat.js342 kB351 kB+8.43 kB (+2.5%)
    firebase-firestore-lite.js133 kB142 kB+9.40 kB (+7.1%)
    firebase-firestore.js443 kB455 kB+11.5 kB (+2.6%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/XqNNYGjltr.html

@google-oss-bot
Copy link
Contributor

Size Analysis Report 1

This report is too large (899,991 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/ehqftt7kSU.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants