Skip to content

fix(auth,messaging): package compatibility #4657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 14, 2021

Conversation

diegogarciar
Copy link
Contributor

@diegogarciar diegogarciar commented Jan 13, 2021

Description

This check ensures that firebase_auth only handles remoteNotifications when firebase_messaging is not present, when firebase_messaging is present, it will send auth messages to firebase_auth.

Related Issues

Fixes #4097
Fixes #4412
Fixes #4388

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • [-] The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

-flutter analyze
warning • The include file package:pedantic/analysis_options.1.8.0.yaml in
/Users/diego/Documents/flutterfire/analysis_options.yaml cannot be found • analysis_options.yaml:1:11 •
include_file_not_found
warning • The include file package:pedantic/analysis_options.1.8.0.yaml in
/Users/diego/Documents/flutterfire/analysis_options.yaml cannot be found • analysis_options.yaml:1:11 •
include_file_not_found

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

This check ensures that firebase_auth only handles remoteNotifications when firebase_messaging is not present, when firebase_messaging is present, it will send auth messages to firebase_auth.
@google-cla google-cla bot added the cla: yes label Jan 13, 2021
@diegogarciar diegogarciar changed the title Fixed Firebase messaging package compatibility fix(auth-messaging): package compatibility Jan 13, 2021
@Salakar Salakar changed the title fix(auth-messaging): package compatibility fix(auth,messaging): package compatibility Jan 14, 2021
@Salakar Salakar merged commit 9db35cc into firebase:master Jan 14, 2021
@firebase firebase locked and limited conversation to collaborators Feb 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
2 participants