Skip to content

add mlkit interpreter 22.0.0 snippets #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 22, 2019

Conversation

thatfiredev
Copy link
Member

@thatfiredev thatfiredev commented Oct 18, 2019

Currently, our automatic build is failing in #141 because MLKit v22.0.0 introduces some breaking changes.

I've also noticed that in order to accommodate these changes, the devsite is no longer loading some of the snippets from this repository.

This PR should:

  • Address the breaking changes to fix our automatic build (using snippets from the devsite);
  • Add the new snippets to this repository so that the devsite can load from here again. PS: the new snippets are under the tags mlkit_model_download_task, mlkit_check_download_status and mlkit_remote_model_download_listener.

@samtstern
Copy link
Contributor

@rosariopfernandes wow thank you! I just want @gkaldev to take a look because I think he was working on the same thing somewhere ekse.

@samtstern samtstern requested a review from gkaldev October 18, 2019 18:38
@gkaldev gkaldev self-assigned this Oct 21, 2019
Copy link
Contributor

@gkaldev gkaldev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@gkaldev gkaldev merged commit a220271 into firebase:master Oct 22, 2019
@thatfiredev thatfiredev deleted the rpf.add-mlkit-snippets branch November 9, 2019 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants