Skip to content

Migrate from logrus to log/slog #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 18 commits into from
Closed

Migrate from logrus to log/slog #586

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
d8c4e0c
moving to slog
jordan-rash Jan 24, 2024
1e322bc
Update go path on buildkite host after go1.21 update
swagatbora90 May 6, 2024
69c7cdc
Skip LogAndMetricis test when running on firecracker version >1.4.x
swagatbora90 May 7, 2024
47f48d9
Bump golang.org/x/net from 0.21.0 to 0.23.0
dependabot[bot] Apr 19, 2024
400c17b
Bump golang.org/x/crypto from 0.22.0 to 0.23.0
dependabot[bot] May 7, 2024
0c070a7
Bump golang.org/x/crypto in /examples/cmd/snapshotting
dependabot[bot] May 6, 2024
cfe3915
Bump github.com/containernetworking/plugins from 1.4.1 to 1.5.0
dependabot[bot] May 20, 2024
1a300ef
run go mod tidy in examples/cmd/snapshotting
swagatbora90 May 28, 2024
fe2b351
Revert update to github.com/containernetworking/[email protected] (#568)
austinvazquez May 28, 2024
4379f6c
Pass firecracker log level through jailer
gudmundur Jun 12, 2024
04c692f
Bump golang.org/x/sys in /examples/cmd/snapshotting (#573)
dependabot[bot] Jun 17, 2024
abfeb6d
Revert "Pass firecracker log level through jailer"
swagatbora90 Jun 24, 2024
4b105a5
Bump golang.org/x/crypto in /examples/cmd/snapshotting
dependabot[bot] Jul 5, 2024
8df47f1
moved logs to debug
jordan-rash Jul 31, 2024
c17fb1c
Merge branch 'firecracker-microvm:main' into main
jordan-rash Jul 31, 2024
9fefbe8
found 2 more
jordan-rash Jul 31, 2024
d284daa
Merge branch 'firecracker-microvm:main' into main
jordan-rash Sep 17, 2024
7eaae45
Merge branch 'firecracker-microvm:main' into main
jordan-rash Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert "Pass firecracker log level through jailer" 
This reverts commit fe67294.

Signed-off-by: Swagat Bora <[email protected]>
Signed-off-by: Jordan Rash <[email protected]>
  • Loading branch information
@swagatbora90 @jordan-rash
swagatbora90 authored and jordan-rash committed Jul 24, 2024
commit abfeb6dd33450caa83e7b6e26f49e12008be6833
4 changes: 0 additions & 4 deletions jailer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,10 +339,6 @@ func jail(ctx context.Context, m *Machine, cfg *Config) error {
fcArgs := seccompArgs(cfg)
fcArgs = append(fcArgs, "--api-sock", machineSocketPath)

if cfg.LogLevel != "" {
fcArgs = append(fcArgs, "--level", cfg.LogLevel)
}

builder := NewJailerCommandBuilder().
WithID(cfg.JailerCfg.ID).
WithUID(*cfg.JailerCfg.UID).
Expand Down