-
Notifications
You must be signed in to change notification settings - Fork 2
Flang extensions #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Guray, this looks good, just a minor change and then I'll approve it.
EXTERN void omp_lib_osnt4_(int num) { omp_set_num_threads(num); } | ||
|
||
EXTERN void omp_lib_osmal4_(int level) { omp_set_max_active_levels(level); } | ||
#endif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add new line here, if you build the runtime within LLVM tree I believe it complains with some warning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I am going to add it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Güray, have you updated this yet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
…s-by-reference as fortran always pass arguments by reference.
I changed the interface of Fortran wrapper library functions from pass-by-value to reference as Fortran always pass arguments by reference. |
The patch generates wrapper device functions for Flang.