Skip to content

Flang extensions #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 28, 2018
Merged

Flang extensions #1

merged 3 commits into from
Nov 28, 2018

Conversation

grypp
Copy link

@grypp grypp commented Oct 17, 2018

The patch generates wrapper device functions for Flang.

Copy link

@simoatze simoatze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guray, this looks good, just a minor change and then I'll approve it.

EXTERN void omp_lib_osnt4_(int num) { omp_set_num_threads(num); }

EXTERN void omp_lib_osmal4_(int level) { omp_set_max_active_levels(level); }
#endif

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add new line here, if you build the runtime within LLVM tree I believe it complains with some warning.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I am going to add it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Güray, have you updated this yet?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@grypp
Copy link
Author

grypp commented Nov 27, 2018

I changed the interface of Fortran wrapper library functions from pass-by-value to reference as Fortran always pass arguments by reference.

@sscalpone sscalpone merged commit 0312af6 into flang-compiler:release_70 Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants