Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@chunhtai
Copy link
Contributor

@chunhtai chunhtai commented Aug 17, 2020

Description

The framework counter part flutter/flutter#82746

The custom action overrides will now be support in ios in favor of adding fake switch control. There is currently no available api to turn on native switch control(scrolling for example) for UIView. We have to workaround it by adding custom actions to imitate those native switch control. This pr makes accessibility bridge in ios to accept custom action overrides for existing semantics action. If it receive such overrides, it will add the imitating custom action into all of its children but itself.

Related Issues

flutter/flutter#37974

Tests

I added the following tests:

see files

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the contributor guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the C++, Objective-C, Java style guides for the engine.
  • I read the tree hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation.
  • All existing and new tests are passing.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read handling breaking changes.

@auto-assign auto-assign bot requested a review from jason-simmons August 17, 2020 18:41
@chinmaygarde chinmaygarde changed the title adding support for ios custom action overrides and expose switch cont… adding support for ios custom action overrides and expose switch control accessibilit feature Sep 17, 2020
@chinmaygarde
Copy link
Member

cc @goderbauer Do you have additional context on how to review and land this? The linked framework PR seems to be open still. If, OTOH, this PR is stale, can we close it for now?

@chunhtai
Copy link
Contributor Author

close until i have time to get back to this pr

@chunhtai chunhtai closed this Sep 17, 2020
@chunhtai chunhtai reopened this Feb 19, 2021
@chunhtai chunhtai added the Work in progress (WIP) Not ready (yet) for review! label Feb 23, 2021
@chunhtai chunhtai force-pushed the issues/37974 branch 2 times, most recently from 7020c98 to 727da96 Compare May 19, 2021 21:23
@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label May 24, 2021
@chunhtai chunhtai changed the title adding support for ios custom action overrides and expose switch control accessibilit feature adding support for ios custom action overrides when switch control is enabled May 25, 2021
@chunhtai chunhtai requested a review from goderbauer June 2, 2021 21:15
@chunhtai chunhtai removed the Work in progress (WIP) Not ready (yet) for review! label Jun 4, 2021
@chunhtai
Copy link
Contributor Author

chunhtai commented Jun 4, 2021

waiting for review

@chunhtai
Copy link
Contributor Author

superseded by #26671

@chunhtai chunhtai closed this Jun 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes platform-ios platform-web Code specifically for the web engine

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants