This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
Reland 3: Display Features support #29585
Merged
blasten
merged 2 commits into
flutter:main
from
andreidiaconu:reland_3_foldable_support
Nov 20, 2021
Merged
Reland 3: Display Features support #29585
blasten
merged 2 commits into
flutter:main
from
andreidiaconu:reland_3_foldable_support
Nov 20, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…flutter#29447)" (flutter#29574)" This reverts commit df686d2.
@blasten As per request from flutter/flutter#93204, we should wait until Engine backlog is cleared. @zanderso Could you please let us know when it's ok to try to reland this? |
8 tasks
Framework PR for landing this: flutter/flutter#93240 |
@blasten I think we are ready to reland this (with flutter/flutter#93240) |
blasten
approved these changes
Nov 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
We need to wait until flutter/plugins#4502 lands before landing this change since it breaks the plugins repo. |
11 tasks
8 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 20, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 20, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 20, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 20, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 20, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 20, 2021
8 tasks
11 tasks
This was referenced Dec 2, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit df686d2.
List which issues are fixed by this PR:
Pre-launch Checklist
writing and running engine tests.
///
).