Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Reland 3: Display Features support #29585

Merged
merged 2 commits into from
Nov 20, 2021

Conversation

andreidiaconu
Copy link
Contributor

@andreidiaconu andreidiaconu commented Nov 8, 2021

This reverts commit df686d2.

List which issues are fixed by this PR:

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added platform-android platform-fuchsia platform-web Code specifically for the web engine labels Nov 8, 2021
@google-cla google-cla bot added the cla: yes label Nov 8, 2021
@andreidiaconu
Copy link
Contributor Author

andreidiaconu commented Nov 8, 2021

@blasten As per request from flutter/flutter#93204, we should wait until Engine backlog is cleared. @zanderso Could you please let us know when it's ok to try to reland this?

@andreidiaconu
Copy link
Contributor Author

Framework PR for landing this: flutter/flutter#93240

@andreidiaconu andreidiaconu marked this pull request as ready for review November 10, 2021 09:14
@andreidiaconu
Copy link
Contributor Author

@blasten I think we are ready to reland this (with flutter/flutter#93240)

Copy link

@blasten blasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@blasten
Copy link

blasten commented Nov 12, 2021

We need to wait until flutter/plugins#4502 lands before landing this change since it breaks the plugins repo.

@CaseyHillers CaseyHillers changed the base branch from master to main November 15, 2021 18:12
@Piinks Piinks self-requested a review November 16, 2021 20:04
@blasten blasten changed the base branch from master to main November 20, 2021 02:03
@blasten blasten merged commit 93f3991 into flutter:main Nov 20, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 20, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 20, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 20, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 20, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants