Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Fallback font match caching to fix emoji lag. #7208

Merged
merged 4 commits into from
Dec 13, 2018

Conversation

GaryQian
Copy link
Contributor

Large emoji string cause lag due to repeated font fallback matching. Here we naively cache the results of MatchFallbackFont.

@GaryQian
Copy link
Contributor Author

Fixes flutter/flutter#24796

@GaryQian GaryQian merged commit eff5e67 into flutter:master Dec 13, 2018
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 13, 2018
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 13, 2018
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Dec 14, 2018
flutter/engine@a549981...101b27d

git log a549981..101b27d --no-merges --oneline
101b27d Roll src/third_party/skia f9e824b8e749..cb6b4bde0c2e (7 commits) (flutter/engine#7215)
eff5e67 Fallback font match caching to fix emoji lag. (flutter/engine#7208)
18a4e33 Downloading and installation of dynamic updates on Android (flutter/engine#7207)
8e56b54 Roll src/third_party/skia 5eb29448dfbd..f9e824b8e749 (10 commits) (flutter/engine#7212)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (liyuqian@google.com), and stop
the roller if necessary.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants