-
Notifications
You must be signed in to change notification settings - Fork 28.5k
Add slider_perf_android
task to ci.yaml
#125540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add slider_perf_android
task to ci.yaml
#125540
Conversation
slider_perf_android
task to .ci.yaml
slider_perf_android
task to ci.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for thinking of putting these benchmarks in place before the big refactoring!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this needs test owner ship defined in https://github.com/flutter/flutter/blob/master/TESTOWNERS
# Test ownership check failed.
Builders missing owner: [Linux_android slider_perf_android]
Please define ownership in https://github.com/flutter/flutter/blob/master/TESTOWNERS
Thank you! I'm adding this task for the first time. |
c8f9024
to
0020a8d
Compare
This adds
devicelab
taskslider_perf_android
to.ci.yaml
, which was added in #125296Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.