[pigeon] removed warnings from generated java code #171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaaclarke
force-pushed
the
pigeon-java-warnings
branch
2 times, most recently
from
4cb85a5 to
be90b5a
Compare
gaaclarke
changed the title
gaaclarke
force-pushed
the
pigeon-java-warnings
branch
from
be90b5a to
47ceefb
Compare
gaaclarke
force-pushed
the
pigeon-java-warnings
branch
from
47ceefb to
14638ad
Compare
blasten
reviewed
Jun 17, 2020
| @@ -178,14 +171,13 @@ String _javaTypeForDartType(String datatype) { | |||
| return _javaTypeForDartTypeMap[datatype]; | |||
| } | |||
|
|
|||
| String _mapGetter(Field field, List<Class> classes, String mapName) { | |||
| String _mapCaster(Field field, List<Class> classes, String varName) { | |||
There was a problem hiding this comment.
Na you are right, doesn't even make sense. Fixed it.
|
Note to future archeologists: master turned red on this PR, the failure is unrelated to the changes in this PR, the fix is in #173. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relevant issue: flutter/flutter#59116