-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[pointer_interceptor] Shadow dom tweaks #364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a couple of questions.
..style.left = '0' | ||
..style.position = 'relative'; | ||
..style.width = '100%' | ||
..style.height = '100%'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this change fine for stable as well? (If not, you could always update the Flutter SDK requirement so Flutter 2.2 won't versions that have this change.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, thanks for asking. I tested this both with stable
and master
, manually and with the driver tests.
This is backwards compatible, it's just that there's many ways to "cover a parent div" with CSS, but in the engine we only check "are style.width and style.height set (to any value?) else: warn user".
This code is to disable that warning from our own packages.
No need to bump a whole z version.
Is this chat still opened? I am trying to avoid reload of iframe url using master/stable channel but can't make it works with slot like you said. Please, help! |
@abnerh69 Please don't spam PRs for help. PRs are for discussing the specific PR, nothing else. |
Change the pointer_interceptor so that it works better with the new
slots
way of embedding HtmlElementViews in flutter web master.Related to: flutter/flutter#80524
Pre-launch Checklist
[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy.CHANGELOG.md
to add a description of the change.///
).If you need help, consider asking for advice on the
#hackers-new
channel on Discord.