Skip to content

[various] Remove unnecessary null checks #4060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 22, 2023
Merged

[various] Remove unnecessary null checks #4060

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
94b9d19
Remove option
stuartmorgan-g May 22, 2023
a507487
Fix warnings
stuartmorgan-g May 22, 2023
1d35bc9
Version bumps
stuartmorgan-g May 22, 2023
3dae072
Fix tool warnings
stuartmorgan-g May 22, 2023
0d2b967
Merge branch 'main' into analysis-options-null-check
stuartmorgan-g May 22, 2023
cb65963
Fix one missed violation
stuartmorgan-g May 22, 2023
7a70ecd
Restore a modified version of a check that is supposed to throw
stuartmorgan-g May 22, 2023
1360a15
Merge remote-tracking branch 'upstream/main' into analysis-options-nu…
stuartmorgan-g May 22, 2023
96b9206
Version change for final fix
stuartmorgan-g May 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix tool warnings
  • Loading branch information
@stuartmorgan-g
stuartmorgan-g committed May 22, 2023
commit 3dae0723d09bf690149394d01944c3f8ccaf9940
4 changes: 2 additions & 2 deletions script/tool/lib/src/common/xcode.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@ class Xcode {
final List<String> args = <String>[
_xcodeBuildCommand,
...actions,
if (workspace != null) ...<String>['-workspace', workspace],
if (scheme != null) ...<String>['-scheme', scheme],
...<String>['-workspace', workspace],
...<String>['-scheme', scheme],
if (configuration != null) ...<String>['-configuration', configuration],
...extraFlags,
];
Expand Down
3 changes: 0 additions & 3 deletions script/tool/lib/src/federation_safety_check_command.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,9 +200,6 @@ class FederationSafetyCheckCommand extends PackageLoopingCommand {

Future<bool> _changeIsCommentOnly(
GitVersionFinder git, String repoPath) async {
if (git == null) {
return false;
}
final List<String> diff = await git.getDiffContents(targetPath: repoPath);
final RegExp changeLine = RegExp(r'^[+-] ');
// This will not catch /**/-style comments, but false negatives are fine
Expand Down
1 change: 0 additions & 1 deletion script/tool/lib/src/publish_command.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,7 +388,6 @@ Safe to ignore if the package is deleted in this commit.
required String tag,
required _RemoteInfo remote,
}) async {
assert(remote != null && tag != null);
if (!getBoolArg(_dryRunFlag)) {
final io.ProcessResult result = await (await gitDir).runCommand(
<String>['push', remote.name, tag],
Expand Down